This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Moved Bytes to own crate
#1141
Merged
Moved Bytes to own crate
#1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
- Coverage 83.59% 83.59% -0.01%
==========================================
Files 366 365 -1
Lines 35901 35851 -50
==========================================
- Hits 30013 29970 -43
+ Misses 5888 5881 -7
Continue to review full report at Codecov.
|
|
cc @jhorstmann @ritchie46 , since both also contributed to this component (either here or in arrow-rs). |
|
LGTM. 👍 |
jorgecarleitao
changed the title
Bytes to own crateBytes to own crate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes that we move the
BytesAPI to another crate so others can use it without having to copy paste. It also separates concerns between this crate (arrow) and a mechanism to use share foreign arrays with Rust still compatible with mutable APIs.Proposed home: https://github.com/DataEngineeringLabs/foreign_vec